Julian/Gitnuro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed flicker when changing tabs

Browse Source
This commit is contained in:
Abdelilah El Aissaoui 2024-07-30 22:26:38 +02:00
parent 26545f4d9c
commit 063aab8507
No known key found for this signature in database
GPG Key ID: 7587FC860F594869
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/main/kotlin/com/jetpackduba/gitnuro/ui/components/TripleVerticalSplitPanel.kt
View File

@ -3,9 +3,6 @@ package com.jetpackduba.gitnuro.ui.components
import androidx.compose.foundation.gestures.Orientation
import androidx.compose.foundation.gestures.draggable
import androidx.compose.foundation.gestures.rememberDraggableState
import androidx.compose.foundation.hoverable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.interaction.collectIsHoveredAsState
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxHeight
@ -36,27 +33,28 @@ fun TripleVerticalSplitPanel(
onThirdSizeDragStopped: () -> Unit,
) {
val density = LocalDensity.current.density
var screenWidth by remember { mutableStateOf(0) }
val screenWidthInDp = remember(screenWidth) { (screenWidth / density) }
val firstWidthLimited = remember(firstWidth, screenWidthInDp) {
calcLimitedWidth(screenWidthInDp, firstWidth)
}
// The panes width used to be calculated in the remember lambda, but as it required the view to compose once to get
// the composable width, it was flickering, so we only update them when size of the parent component changes
var firstWidthLimited by remember(firstWidth) { mutableStateOf(firstWidth)}
var thirdWidthLimited by remember(thirdWidth) { mutableStateOf(thirdWidth) }
val thirdWidthLimited = remember(thirdWidth, screenWidthInDp) {
calcLimitedWidth(screenWidthInDp, thirdWidth)
fun updateMaxPaneWidthToComponentWidth(screenWidth: Int) {
val screenWidthInDp = screenWidth /density
firstWidthLimited = calcLimitedWidth(screenWidthInDp, firstWidth)
thirdWidthLimited = calcLimitedWidth(screenWidthInDp, thirdWidth)
}
Row(
modifier = modifier
.onSizeChanged {
screenWidth = it.width
updateMaxPaneWidthToComponentWidth(it.width)
}
) {
if (firstWidth > 0) {
Box(
modifier = Modifier
.width(firstWidthLimited.dp)
.width(firstWidth.dp)
) {
first()
}
@ -108,7 +106,7 @@ fun TripleVerticalSplitPanel(
Box(
modifier = Modifier
.width(thirdWidthLimited.dp)
.width(thirdWidth.dp)
) {
third()
}