From 27d28cfdce25c915ca6aca6e6d85dc0a40ee6e9a Mon Sep 17 00:00:00 2001 From: Abdelilah El Aissaoui Date: Sat, 11 Jun 2022 23:46:56 +0200 Subject: [PATCH] OnClick is now null on default for SideMenuSubentry. Implementing an empty callback would break the behavior of the VerticalExpandable. --- src/main/kotlin/app/ui/components/SideMenuSubentry.kt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/kotlin/app/ui/components/SideMenuSubentry.kt b/src/main/kotlin/app/ui/components/SideMenuSubentry.kt index e0827bf..90966e3 100644 --- a/src/main/kotlin/app/ui/components/SideMenuSubentry.kt +++ b/src/main/kotlin/app/ui/components/SideMenuSubentry.kt @@ -28,7 +28,7 @@ fun SideMenuSubentry( iconResourcePath: String, bold: Boolean = false, extraPadding: Dp = 0.dp, - onClick: () -> Unit = {}, + onClick: (() -> Unit)? = null, onDoubleClick: (() -> Unit)? = null, additionalInfo: @Composable () -> Unit = {} ) { @@ -36,7 +36,12 @@ fun SideMenuSubentry( modifier = Modifier .height(ENTRY_HEIGHT.dp) .fillMaxWidth() - .combinedClickable(onClick = onClick, onDoubleClick = onDoubleClick) + .run { + if(onClick != null) + combinedClickable(onClick = onClick, onDoubleClick = onDoubleClick) + else + this + } .padding(start = extraPadding), verticalAlignment = Alignment.CenterVertically, ) {