Changed design of uncommited changes

This commit is contained in:
Abdelilah El Aissaoui 2022-10-18 23:43:55 +02:00
parent ad1cdb884b
commit 438bea4788
2 changed files with 19 additions and 18 deletions

View File

@ -303,7 +303,6 @@ fun CommitLogChanges(
Spacer(modifier = Modifier.weight(2f)) Spacer(modifier = Modifier.weight(2f))
Divider()
} }
} }
} }

View File

@ -11,7 +11,7 @@ import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.interaction.collectIsHoveredAsState import androidx.compose.foundation.interaction.collectIsHoveredAsState
import androidx.compose.foundation.layout.* import androidx.compose.foundation.layout.*
import androidx.compose.foundation.lazy.LazyListState import androidx.compose.foundation.lazy.LazyListState
import androidx.compose.foundation.lazy.itemsIndexed import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.shape.CornerSize import androidx.compose.foundation.shape.CornerSize
import androidx.compose.material.* import androidx.compose.material.*
import androidx.compose.material.icons.Icons import androidx.compose.material.icons.Icons
@ -28,19 +28,19 @@ import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextAlign import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import com.jetpackduba.gitnuro.extensions.*
import com.jetpackduba.gitnuro.git.DiffEntryType import com.jetpackduba.gitnuro.git.DiffEntryType
import com.jetpackduba.gitnuro.git.workspace.StatusEntry import com.jetpackduba.gitnuro.git.workspace.StatusEntry
import com.jetpackduba.gitnuro.git.workspace.StatusType import com.jetpackduba.gitnuro.git.workspace.StatusType
import com.jetpackduba.gitnuro.keybindings.KeybindingOption import com.jetpackduba.gitnuro.keybindings.KeybindingOption
import com.jetpackduba.gitnuro.keybindings.matchesBinding import com.jetpackduba.gitnuro.keybindings.matchesBinding
import com.jetpackduba.gitnuro.theme.*
import com.jetpackduba.gitnuro.ui.components.ScrollableLazyColumn import com.jetpackduba.gitnuro.ui.components.ScrollableLazyColumn
import com.jetpackduba.gitnuro.ui.components.SecondaryButton import com.jetpackduba.gitnuro.ui.components.SecondaryButton
import com.jetpackduba.gitnuro.viewmodels.StageStatus
import com.jetpackduba.gitnuro.viewmodels.StatusViewModel
import com.jetpackduba.gitnuro.extensions.*
import com.jetpackduba.gitnuro.theme.*
import com.jetpackduba.gitnuro.ui.components.gitnuroViewModel import com.jetpackduba.gitnuro.ui.components.gitnuroViewModel
import com.jetpackduba.gitnuro.ui.context_menu.* import com.jetpackduba.gitnuro.ui.context_menu.*
import com.jetpackduba.gitnuro.viewmodels.StageStatus
import com.jetpackduba.gitnuro.viewmodels.StatusViewModel
import org.eclipse.jgit.lib.RepositoryState import org.eclipse.jgit.lib.RepositoryState
@Composable @Composable
@ -88,7 +88,11 @@ fun UncommitedChanges(
} }
} }
Column { Column(
modifier = Modifier
.padding(end = 8.dp, bottom = 8.dp)
.fillMaxWidth()
) {
AnimatedVisibility( AnimatedVisibility(
visible = isLoading, visible = isLoading,
enter = fadeIn(), enter = fadeIn(),
@ -99,8 +103,8 @@ fun UncommitedChanges(
EntriesList( EntriesList(
modifier = Modifier modifier = Modifier
.padding(end = 8.dp, bottom = 4.dp)
.weight(5f) .weight(5f)
.padding(bottom = 4.dp)
.fillMaxWidth(), .fillMaxWidth(),
title = "Staged", title = "Staged",
allActionTitle = "Unstage all", allActionTitle = "Unstage all",
@ -130,8 +134,8 @@ fun UncommitedChanges(
EntriesList( EntriesList(
modifier = Modifier modifier = Modifier
.padding(end = 8.dp, top = 8.dp)
.weight(5f) .weight(5f)
.padding(bottom = 4.dp)
.fillMaxWidth(), .fillMaxWidth(),
title = "Unstaged", title = "Unstaged",
actionTitle = "Stage", actionTitle = "Stage",
@ -164,7 +168,6 @@ fun UncommitedChanges(
Column( Column(
modifier = Modifier modifier = Modifier
.padding(top = 8.dp, bottom = 8.dp, end = 8.dp)
.height(192.dp) .height(192.dp)
.fillMaxWidth() .fillMaxWidth()
) { ) {
@ -482,7 +485,6 @@ fun ConfirmationButton(
} }
} }
@OptIn(ExperimentalFoundationApi::class)
@Composable @Composable
private fun EntriesList( private fun EntriesList(
modifier: Modifier, modifier: Modifier,
@ -502,10 +504,14 @@ private fun EntriesList(
Column( Column(
modifier = modifier modifier = modifier
) { ) {
Box { Box(
modifier = Modifier
.height(34.dp)
.fillMaxWidth()
.background(color = MaterialTheme.colors.headerBackground)
) {
Text( Text(
modifier = Modifier modifier = Modifier
.background(color = MaterialTheme.colors.headerBackground)
.padding(vertical = 8.dp, horizontal = 16.dp) .padding(vertical = 8.dp, horizontal = 16.dp)
.fillMaxWidth(), .fillMaxWidth(),
text = title, text = title,
@ -531,7 +537,7 @@ private fun EntriesList(
.background(MaterialTheme.colors.background), .background(MaterialTheme.colors.background),
state = lazyListState, state = lazyListState,
) { ) {
itemsIndexed(statusEntries) { index, statusEntry -> items(statusEntries) { statusEntry ->
val isEntrySelected = selectedEntryType != null && val isEntrySelected = selectedEntryType != null &&
selectedEntryType is DiffEntryType.UncommitedDiff && // Added for smartcast selectedEntryType is DiffEntryType.UncommitedDiff && // Added for smartcast
selectedEntryType.statusEntry == statusEntry selectedEntryType.statusEntry == statusEntry
@ -548,10 +554,6 @@ private fun EntriesList(
}, },
onGenerateContextMenu = onGenerateContextMenu, onGenerateContextMenu = onGenerateContextMenu,
) )
if (index < statusEntries.size - 1) {
Divider(modifier = Modifier.fillMaxWidth())
}
} }
} }
} }