Removed no longer valid TODOs
This commit is contained in:
parent
3bea4f22e8
commit
55ebd9ee0d
@ -67,7 +67,6 @@ class GRemoteSession @Inject constructor(
|
||||
|
||||
var credentials = credentialsStateManager.currentCredentialsState
|
||||
while (credentials is CredentialsState.CredentialsRequested) {
|
||||
// TODO check if support for ED25519 with pwd can be added
|
||||
credentials = credentialsStateManager.currentCredentialsState
|
||||
}
|
||||
|
||||
|
@ -48,18 +48,18 @@ class RebaseManager @Inject constructor(
|
||||
.call()
|
||||
}
|
||||
|
||||
suspend fun rebaseInteractive(git: Git, interactiveHandler: InteractiveHandler, commit: RevCommit) {
|
||||
//TODO Check possible rebase errors by checking the result
|
||||
val rebaseResult = git.rebase()
|
||||
.runInteractively(interactiveHandler)
|
||||
.setOperation(RebaseCommand.Operation.BEGIN)
|
||||
.setUpstream(commit)
|
||||
.call()
|
||||
suspend fun rebaseInteractive(git: Git, interactiveHandler: InteractiveHandler, commit: RevCommit) =
|
||||
withContext(Dispatchers.IO) {
|
||||
val rebaseResult = git.rebase()
|
||||
.runInteractively(interactiveHandler)
|
||||
.setOperation(RebaseCommand.Operation.BEGIN)
|
||||
.setUpstream(commit)
|
||||
.call()
|
||||
|
||||
if (rebaseResult.status == RebaseResult.Status.FAILED) {
|
||||
throw UncommitedChangesDetectedException("Rebase interactive failed.")
|
||||
if (rebaseResult.status == RebaseResult.Status.FAILED) {
|
||||
throw UncommitedChangesDetectedException("Rebase interactive failed.")
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
suspend fun rebaseLinesFullMessage(
|
||||
git: Git,
|
||||
|
@ -7,7 +7,7 @@ class UncommitedChangesGraphNode : GraphNode(ObjectId(0, 0, 0, 0, 0)) {
|
||||
var graphParent: GraphNode? = null
|
||||
|
||||
override val graphParentCount: Int
|
||||
get() = 1 // TODO: Check what happens with an empty tree
|
||||
get() = 1 // Uncommited changes can have a max of 1 parent commit
|
||||
|
||||
override fun getGraphParent(nth: Int): GraphNode {
|
||||
return requireNotNull(graphParent)
|
||||
|
@ -42,7 +42,7 @@ data class ColorsScheme(
|
||||
onBackground = this.primaryText,
|
||||
onSurface = this.primaryText,
|
||||
onError = this.onError,
|
||||
isLight = true, // todo what is this used for? Hardcoded value for now
|
||||
isLight = true, // property specific for some colors, we don't care about this as all our components are customized
|
||||
)
|
||||
}
|
||||
}
|
@ -25,8 +25,6 @@ import app.viewmodels.RepositorySelectionStatus
|
||||
import app.viewmodels.TabViewModel
|
||||
import kotlinx.coroutines.delay
|
||||
|
||||
// TODO onDispose sometimes is called when changing tabs, therefore losing the tab state
|
||||
@OptIn(ExperimentalAnimationApi::class)
|
||||
@Composable
|
||||
fun AppTab(
|
||||
tabViewModel: TabViewModel,
|
||||
|
Loading…
Reference in New Issue
Block a user