Julian/Gitnuro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added explanatory message for unsupported "manager-core"

Browse Source
This commit is contained in:
Abdelilah El Aissaoui 2022-10-08 20:04:25 +02:00
parent 7bdc2c4cf5
commit 9109f179df
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/kotlin/com/jetpackduba/gitnuro/credentials/HttpCredentialsProvider.kt
View File

@ -201,10 +201,15 @@ class HttpCredentialsProvider @AssistedInject constructor(
val genericCredentialHelper = config.getString("credential", null, "helper") val genericCredentialHelper = config.getString("credential", null, "helper")
val uriSpecificCredentialHelper = config.getString("credential", hostWithProtocol, "helper") val uriSpecificCredentialHelper = config.getString("credential", hostWithProtocol, "helper")
val credentialHelperPath = uriSpecificCredentialHelper ?: genericCredentialHelper ?: return null var credentialHelperPath = uriSpecificCredentialHelper ?: genericCredentialHelper ?: return null
if(credentialHelperPath == "cache" || credentialHelperPath == "store") { if(credentialHelperPath == "cache" || credentialHelperPath == "store") {
throw NotSupportedHelper("Invalid credentials: \"$credentialHelperPath\" is not yet supported") throw NotSupportedHelper("Invalid credentials helper: \"$credentialHelperPath\" is not yet supported")
}
// TODO Try to use "git-credential-manager-core" when "manager-core" is detected. Works for linux but requires testing for mac/windows
if(credentialHelperPath == "manager-core") {
throw NotSupportedHelper("Invalid credentials helper \"$credentialHelperPath\". Please specify the full path of Git Credential Manager in your .gitconfig")
} }
// Use getString instead of getBoolean as boolean has a default value by we want null if the config field is not set // Use getString instead of getBoolean as boolean has a default value by we want null if the config field is not set