From db1467c354c2f2537659e97fd3d5c815a9921482 Mon Sep 17 00:00:00 2001 From: Abdelilah El Aissaoui Date: Thu, 31 Oct 2024 01:37:49 +0100 Subject: [PATCH] Having "cache" or "store" in credentials manager config does not longer throw an error --- .../gitnuro/credentials/HttpCredentialsProvider.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/kotlin/com/jetpackduba/gitnuro/credentials/HttpCredentialsProvider.kt b/src/main/kotlin/com/jetpackduba/gitnuro/credentials/HttpCredentialsProvider.kt index e95cee8..76fe467 100644 --- a/src/main/kotlin/com/jetpackduba/gitnuro/credentials/HttpCredentialsProvider.kt +++ b/src/main/kotlin/com/jetpackduba/gitnuro/credentials/HttpCredentialsProvider.kt @@ -2,6 +2,7 @@ package com.jetpackduba.gitnuro.credentials import com.jetpackduba.gitnuro.exceptions.NotSupportedHelper import com.jetpackduba.gitnuro.git.remote_operations.CredentialsCache +import com.jetpackduba.gitnuro.logging.printError import com.jetpackduba.gitnuro.logging.printLog import com.jetpackduba.gitnuro.managers.IShellManager import com.jetpackduba.gitnuro.repositories.AppSettingsRepository @@ -259,7 +260,8 @@ class HttpCredentialsProvider @AssistedInject constructor( val credentialHelperPath = uriSpecificCredentialHelper ?: genericCredentialHelper ?: return null if (credentialHelperPath == "cache" || credentialHelperPath == "store") { - throw NotSupportedHelper("Invalid credentials helper: \"$credentialHelperPath\" is not yet supported") + printError(TAG, "Invalid credentials helper: \"$credentialHelperPath\" is not yet supported") + return null } // TODO Try to use "git-credential-manager-core" when "manager-core" is detected. Works for linux but requires testing for mac/windows